lkml.org 
[lkml]   [2018]   [Jan]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: [PATCH] input: cyapa: remove redundant assignment to 'pwr_cmd'
    On Wed, Jan 17, 2018 at 10:45:19AM +0000, Colin King wrote:
    > From: Colin Ian King <colin.king@canonical.com>
    >
    > The variable pwr_cmd is being assigned to cyapa->suspend_power_mode
    > twice, once during the declaration and once after taking an
    > interruptible mutex lock. Remove the redundant first assignment
    > since the value is never read and it is outside the mutex lock.
    >
    > Cleans up clang warning:
    > drivers/input/mouse/cyapa.c:743:5: warning: Value stored to 'pwr_cmd'
    > during its initialization is never read
    >
    > Signed-off-by: Colin Ian King <colin.king@canonical.com>

    Applied, thank you.

    > ---
    > drivers/input/mouse/cyapa.c | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > diff --git a/drivers/input/mouse/cyapa.c b/drivers/input/mouse/cyapa.c
    > index fd8865c65caf..dfd3873513e4 100644
    > --- a/drivers/input/mouse/cyapa.c
    > +++ b/drivers/input/mouse/cyapa.c
    > @@ -740,7 +740,7 @@ static ssize_t cyapa_show_suspend_scanrate(struct device *dev,
    > char *buf)
    > {
    > struct cyapa *cyapa = dev_get_drvdata(dev);
    > - u8 pwr_cmd = cyapa->suspend_power_mode;
    > + u8 pwr_cmd;
    > u16 sleep_time;
    > int len;
    > int error;
    > --
    > 2.15.1
    >

    --
    Dmitry

    \
     
     \ /
      Last update: 2018-01-18 20:23    [W:4.859 / U:0.636 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site