Messages in this thread | | | Date | Thu, 18 Jan 2018 10:50:15 -0800 | From | Andi Kleen <> | Subject | Re: [PATCH v1 tip/master 0/3] kprobes/x86: retpoline: Fix kprobes for retpoline |
| |
On Thu, Jan 18, 2018 at 02:03:07PM +0100, David Woodhouse wrote: > On Thu, 2018-01-18 at 05:01 -0800, Andi Kleen wrote: > > > > > > Side effect: [1/3] will move __x86_indirect_thunk_* functions > > > in kernel text area. Of course those functions were in the > > > .text area, but placed in right after _etext. This just moves > > > it right before the _etext. > > I assume you tested that with page table isolation on? > > > > The thunks need to be accessible from the trampoline. > > I thought we put it inline in the trampoline.
Yes we did, just want to make sure everything still works.
If it's tested that's fine
-Andi
| |