lkml.org 
[lkml]   [2018]   [Jan]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 1/2] nvme: add tracepoint for nvme_setup_cmd
On Wed, Jan 17, 2018 at 11:53:35AM +0100, Johannes Thumshirn wrote:
> +nvme-core-y := trace.o core.o

trace.o should be conditional on CONFIG_TRACEPOINTS.

> +TRACE_EVENT(nvme_setup_cmd,
> + TP_PROTO(struct nvme_command *cmd),
> + TP_ARGS(cmd),
> + TP_STRUCT__entry(
> + __field(__u8, opcode)
> + __field(__u8, flags)
> + __field(__u16, cid)
> + __field(__le32, nsid)
> + __field(__le64, metadata)
> + __field_struct( struct nvme_command, cmnd )

This still copies the whole SQE. I think that is way to much to
copy, especially given that you also copy many of the fields separately
as well.

\
 
 \ /
  Last update: 2018-01-18 16:22    [W:0.073 / U:0.212 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site