lkml.org 
[lkml]   [2018]   [Jan]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 03/10] x86: Add a type field to alt_instr
    On Tue, Jan 16, 2018 at 03:28:28PM +0100, Peter Zijlstra wrote:
    > Add a type field to the alternative description. For now this will be
    > used to annotate static_cpu_has() but possible future uses include
    > using it to implement alternative alignment and special NOP handling.
    >
    > Suggested-by: Borislav Petkov <bp@alien8.de>
    > Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
    > ---
    > arch/x86/include/asm/alternative-asm.h | 3 ++-
    > arch/x86/include/asm/alternative.h | 6 +++++-

    There's a

    DPRINTK("feat: %d*32+%d, old: (%p, len: %d), repl: (%p, len: %d), pad: %d",

    in arch/x86/kernel/alternative.c which dumps the whole alt_instr struct
    for debugging. Please add the type there too.

    With that and Josh's suggestion added:

    Reviewed-by: Borislav Petkov <bp@suse.de>

    --
    Regards/Gruss,
    Boris.

    Good mailing practices for 400: avoid top-posting and trim the reply.

    \
     
     \ /
      Last update: 2018-01-18 12:32    [W:3.123 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site