lkml.org 
[lkml]   [2018]   [Jan]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 0/3] tracing: Fix the parser when processing strings w/ or w/o terminated '\0'
On Wed, Jan 17, 2018 at 02:45:24PM +0900, Namhyung Kim wrote:
> Hello,
>
> On Wed, Jan 17, 2018 at 12:54:34PM +0800, Du, Changbin wrote:
> > On Tue, Jan 16, 2018 at 12:42:26PM -0500, Steven Rostedt wrote:
> > > On Tue, 16 Jan 2018 17:02:27 +0800
> > > changbin.du@intel.com wrote:
> > >
> > > > From: Changbin Du <changbin.du@intel.com>
> > > >
> > > > I found there are some problems in the tracing parser when I investiage the root
> > > > cause of issues mentioned in below patch.
> > > > https://patchwork.kernel.org/patch/10132953/
> > >
> > > I pulled in your patches and tweaked the change logs of the other two
> > > patches as well. You can see my temporary git tree here, but it may
> > > rebase.
> > >
> > > git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace.git
> > >
> > > ftrace/core
> > >
> > > -- Steve
> > Got it. Thank you!
> >
> > Hi Olsa, so the perf patch 'perf ftrace: Fix the buffer size in__write_tracing_file'
> > is still needed. I will resend you at appropriate time.
>
> But it will work on the future kernels only, right? For tools to be
> compatible with old kernels, you'd better writing a whitespace after
> the function name IMHO.
>
Yes, it needs to write a space if it doesn't want possible error hidden.

> Thanks,
> Namhyung

--
Thanks,
Changbin Du

\
 
 \ /
  Last update: 2018-01-18 00:20    [W:0.039 / U:2.008 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site