Messages in this thread | | | Subject | Re: [PATCH -next] ipmi/powernv: Fix error return code in ipmi_powernv_probe() | From | Alexey Kardashevskiy <> | Date | Thu, 18 Jan 2018 15:04:50 +1100 |
| |
On 17/01/18 22:25, Wei Yongjun wrote: > Fix to return a negative error code from the request_irq() error > handling case instead of 0, as done elsewhere in this function. > > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Reviewed-by: Alexey Kardashevskiy <aik@ozlabs.ru>
> --- > drivers/char/ipmi/ipmi_powernv.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/char/ipmi/ipmi_powernv.c b/drivers/char/ipmi/ipmi_powernv.c > index c687c8d..bcf493d 100644 > --- a/drivers/char/ipmi/ipmi_powernv.c > +++ b/drivers/char/ipmi/ipmi_powernv.c > @@ -250,8 +250,9 @@ static int ipmi_powernv_probe(struct platform_device *pdev) > ipmi->irq = opal_event_request(prop); > } > > - if (request_irq(ipmi->irq, ipmi_opal_event, IRQ_TYPE_LEVEL_HIGH, > - "opal-ipmi", ipmi)) { > + rc = request_irq(ipmi->irq, ipmi_opal_event, IRQ_TYPE_LEVEL_HIGH, > + "opal-ipmi", ipmi); > + if (rc) { > dev_warn(dev, "Unable to request irq\n"); > goto err_dispose; > } >
-- Alexey
| |