lkml.org 
[lkml]   [2018]   [Jan]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 01/10] perf tools: Integrating the CoreSight decoding library
On Tue, Jan 16, 2018 at 01:15:00PM +0100, Jiri Olsa wrote:
> On Mon, Jan 15, 2018 at 11:13:05AM -0700, Mathieu Poirier wrote:
> > The Open CoreSight Decoding Library (openCSD) is a free and open
> > library to decode traces collected by the CoreSight hardware
> > infrastructure.
> >
> > This patch adds the required mechanic to recognise the presence
> > of the openCSD library on a system and set up miscellaneous flags
> > to be used in the compilation of the trace decoding feature.
> >
> > Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
> > ---
> > tools/build/Makefile.feature | 6 ++++--
> > tools/build/feature/Makefile | 7 ++++++-
> > tools/build/feature/test-all.c | 5 +++++
> > tools/build/feature/test-libopencsd.c | 8 ++++++++
> > tools/perf/Makefile.config | 25 +++++++++++++++++++++++++
> > tools/perf/Makefile.perf | 2 ++
> > 6 files changed, 50 insertions(+), 3 deletions(-)
> > create mode 100644 tools/build/feature/test-libopencsd.c
> >
> > diff --git a/tools/build/Makefile.feature b/tools/build/Makefile.feature
> > index e52fcefee379..dc3d97b248ab 100644
> > --- a/tools/build/Makefile.feature
> > +++ b/tools/build/Makefile.feature
> > @@ -66,7 +66,8 @@ FEATURE_TESTS_BASIC := \
> > bpf \
> > sched_getcpu \
> > sdt \
> > - setns
> > + setns \
> > + libopencsd
> >
> > # FEATURE_TESTS_BASIC + FEATURE_TESTS_EXTRA is the complete list
> > # of all feature tests
> > @@ -108,7 +109,8 @@ FEATURE_DISPLAY ?= \
> > zlib \
> > lzma \
> > get_cpuid \
> > - bpf
> > + bpf \
> > + libopencsd
>
> we put in this list only generic libraries, this one seems arch
> specific please put it into FEATURE_TESTS_EXTRA list

Very well - thanks for taking the time to review my work.
Mathieu

>
> the state is displayed by running make 'VF=1', with this patch:
> https://marc.info/?l=linux-kernel&m=151549001914932&w=2
>
> Arnaldo, could you please check on that one ^^^?
>
> thanks,
> jirka

\
 
 \ /
  Last update: 2018-01-16 19:05    [W:0.084 / U:3.736 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site