| Date | Tue, 16 Jan 2018 10:44:09 +0100 | From | Wolfram Sang <> | Subject | Re: [PATCH v2 18/22] mmc: tmio: remove useless TMIO_MASK_CMD handling in tmio_mmc_host_probe() |
| |
On Sat, Nov 25, 2017 at 01:24:53AM +0900, Masahiro Yamada wrote: > TMIO_MASK_CMD is properly enabled in tmio_mmc_start_command(). > > We have no reason to set it up in tmio_mmc_host_probe(). (If we > really wanted to set it in the probe, we would have to do likewise > when resuming.) > > Even worse, the following code is extremely confusing: > > _host->sdcard_irq_mask &= ~irq_mask; > > The logic is opposite between "->sdcard_irq_mask" and "irq_mask". > The intention is not clear at a glance. > > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
In general, I like it a lot. It just depends on the previous patches which are still subject to discussion.
[unhandled content-type:application/pgp-signature] |