lkml.org 
[lkml]   [2018]   [Jan]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH V4 5/8] perf/x86/intel/uncore: add infrastructure for free running counter
Date
> On Thu, 2 Nov 2017, kan.liang@intel.com wrote:
>
> > From: Kan Liang <Kan.liang@intel.com>
> >
> > The free running counter is read-only and always active. Current generic
> > uncore code does not support this kind of counters.
> >
> > The free running counter is read-only. It cannot be enable/disable in
> > event_start/stop.
> > The free running counter event and free running counter are 1:1 mapped.
> > It doesn't need to be assigned nor tracked by event_list.
> > The free running counters are always active. It doesn't need to check
> > the free running counters' availability.
> >
> > Use inline helpers to check fixed counter index and free running counter
> > index.
> >
>
> That changelog is horrible to read. Other than that:
>

Hi Thomas,

Thanks for your review.

Sorry about the changelog.
I will modify the changelog and resend all the patches.

Thanks,
Kan

> Reviewed-by: Thomas Gleixner <tglx@linutronix.de>

\
 
 \ /
  Last update: 2018-01-15 16:54    [W:0.086 / U:0.252 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site