lkml.org 
[lkml]   [2018]   [Jan]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/4] tsi108_eth: use dma API properly
On Wed, Jan 10, 2018 at 10:09:20PM +0200, Andy Shevchenko wrote:
> > + struct platform_device *pdev;
>
> Do you really need platform_defice reference?
>
> Perhaps
>
> struct device *hdev; // hardware device
>
>
> data->hdev = &pdev->dev;
>
> Another idea
>
> dev->dev.parent = &pdev->dev;
>
> No new member needed.

Maybe. But what I've done is the simplest change in a long obsolete
driver that I don't understand at all. I'd rather keep it simple.

\
 
 \ /
  Last update: 2018-01-15 16:12    [W:0.060 / U:31.596 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site