lkml.org 
[lkml]   [2018]   [Jan]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 4/4] ASoC: codecs: tas5720: add TAS5722 TDM slot width setting support
From
Date
On 12/12/2017 06:02 AM, Mark Brown wrote:
> On Mon, Dec 11, 2017 at 01:01:57PM -0600, Andrew F. Davis wrote:
>
>> + /* Configure TDM slot width. This is only applicable to TAS5722. */
>> + if (tas5720->devtype == TAS5722) {
>> + ret = snd_soc_update_bits(codec, TAS5722_DIGITAL_CTRL2_REG,
>> + TAS5722_TDM_SLOT_16B,
>> + slot_width == 16 ?
>> + TAS5722_TDM_SLOT_16B : 0);
>> + if (ret < 0)
>> + goto error_snd_soc_update_bits;
>> + }
>
> Use a switch statement, that way additional variants can be handled more
> sensibly.
>

Will fix.

\
 
 \ /
  Last update: 2018-01-15 15:52    [W:0.074 / U:1.428 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site