lkml.org 
[lkml]   [2018]   [Jan]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 035/118] phylink: ensure we report link down when LOS asserted
    Date
    4.14-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Russell King <rmk+kernel@armlinux.org.uk>


    [ Upstream commit ac817f5ad066697e4d4d35ec68c974eba2c5f17a ]

    Although we disable the netdev carrier, we fail to report in the kernel
    log that the link went down. Fix this.

    Fixes: 9525ae83959b ("phylink: add phylink infrastructure")
    Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
    Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/net/phy/phylink.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    --- a/drivers/net/phy/phylink.c
    +++ b/drivers/net/phy/phylink.c
    @@ -1428,9 +1428,8 @@ static void phylink_sfp_link_down(void *
    WARN_ON(!lockdep_rtnl_is_held());

    set_bit(PHYLINK_DISABLE_LINK, &pl->phylink_disable_state);
    + queue_work(system_power_efficient_wq, &pl->resolve);
    flush_work(&pl->resolve);
    -
    - netif_carrier_off(pl->netdev);
    }

    static void phylink_sfp_link_up(void *upstream)

    \
     
     \ /
      Last update: 2018-01-15 14:20    [W:4.318 / U:0.156 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site