lkml.org 
[lkml]   [2018]   [Jan]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 61/87] drm/vmwgfx: Potential off by one in vmw_view_add()
    Date
    4.4-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Dan Carpenter <dan.carpenter@oracle.com>

    commit 0d9cac0ca0429830c40fe1a4e50e60f6221fd7b6 upstream.

    The vmw_view_cmd_to_type() function returns vmw_view_max (3) on error.
    It's one element beyond the end of the vmw_view_cotables[] table.

    My read on this is that it's possible to hit this failure. header->id
    comes from vmw_cmd_check() and it's a user controlled number between
    1040 and 1225 so we can hit that error. But I don't have the hardware
    to test this code.

    Fixes: d80efd5cb3de ("drm/vmwgfx: Initial DX support")
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Reviewed-by: Thomas Hellstrom <thellstrom@vmware.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c | 2 ++
    1 file changed, 2 insertions(+)

    --- a/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c
    +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c
    @@ -2678,6 +2678,8 @@ static int vmw_cmd_dx_view_define(struct
    }

    view_type = vmw_view_cmd_to_type(header->id);
    + if (view_type == vmw_view_max)
    + return -EINVAL;
    cmd = container_of(header, typeof(*cmd), header);
    ret = vmw_cmd_res_check(dev_priv, sw_context, vmw_res_surface,
    user_surface_converter,

    \
     
     \ /
      Last update: 2018-01-15 13:43    [W:4.271 / U:0.260 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site