lkml.org 
[lkml]   [2018]   [Jan]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] bcma: Fix 'allmodconfig' and BCMA builds on MIPS targets
Date
Guenter Roeck <linux@roeck-us.net> writes:

> [ copying linux-mips ]
>
> On 01/14/2018 01:34 PM, Guenter Roeck wrote:
>> Mips builds with BCMA host mode enabled fail in mainline and -next
>> with:
>>
>> In file included from include/linux/bcma/bcma.h:10:0,
>> from drivers/bcma/bcma_private.h:9,
>> from drivers/bcma/main.c:8:
>> include/linux/bcma/bcma_driver_pci.h:218:24: error:
>> field 'pci_controller' has incomplete type
>>
>> Bisect points to commit d41e6858ba58c ("MIPS: Kconfig: Set default MIPS
>> system type as generic") as the culprit. Analysis shows that the commmit
>> changes PCI configuration and enables PCI_DRIVERS_GENERIC. This in turn
>> disables PCI_DRIVERS_LEGACY. 'struct pci_controller' is, however, only
>> defined if PCI_DRIVERS_LEGACY is enabled.
>>
>> Ultimately that means that BCMA_DRIVER_PCI_HOSTMODE depends on
>> PCI_DRIVERS_LEGACY. Add the missing dependency.
>>
>> Fixes: d41e6858ba58c ("MIPS: Kconfig: Set default MIPS system type as ...")
>> Cc: Matt Redfearn <matt.redfearn@imgtec.com>
>> Cc: James Hogan <jhogan@kernel.org>
>> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
>> ---
>> I am aware that this problem has been reported several times. I have
>> not been able to find a fix, but I may have missed it. If so, my
>> apologies for the noise.
>>
> I should have said "I have not been able to find a patch fixing it".
>
>> Also note that this is not the only fix required; commit d41e6858ba58c,
>> as simple as it looks like, does a pretty good job messing up
>> "mips:allmodconfig" builds.
>>
> ... nor did I find patch(es) fixing the other build problem(s) introduced
> by d41e6858ba58c.

As I forgot to cc linux-mips on my previous email: I'm planning to queue
this for v4.15.

Over the weeked I got this bcma patch, but don't know if it's related or
not:

bcma: Prevent build of PCI host features in module
https://patchwork.kernel.org/patch/10161087/

And Guenter's patch is:

https://patchwork.kernel.org/patch/10162839/

Which one should I take? Adding also Matt.

And Matt also submitted similar patch for ssb:

ssb: Prevent build of PCI host features in module
https://patchwork.kernel.org/patch/10161131/

--
Kalle Valo

\
 
 \ /
  Last update: 2018-01-15 11:12    [W:0.057 / U:9.860 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site