lkml.org 
[lkml]   [2018]   [Jan]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] powerpc/xive: Properly use static keyword for inline function
From
Date
On 12/26/2017 02:00 PM, Mathieu Malaterre wrote:
> Fix fatal warning during compilation:
>
> In file included from arch/powerpc/xmon/xmon.c:54:0:
> ./arch/powerpc/include/asm/xive.h:157:20: error: no previous prototype for ‘xive_smp_prepare_cpu’ [-Werror=missing-prototypes]
> extern inline int xive_smp_prepare_cpu(unsigned int cpu) { return -EINVAL; }
> ^
>
> Signed-off-by: Mathieu Malaterre <malat@debian.org>

Reviewed-by: Cédric Le Goater <clg@kaod.org>

Thanks,

C.

> ---
> arch/powerpc/include/asm/xive.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/include/asm/xive.h b/arch/powerpc/include/asm/xive.h
> index 371fbebf1ec9..83dc2cc320a3 100644
> --- a/arch/powerpc/include/asm/xive.h
> +++ b/arch/powerpc/include/asm/xive.h
> @@ -154,7 +154,7 @@ static inline bool xive_enabled(void) { return false; }
> static inline bool xive_spapr_init(void) { return false; }
> static inline bool xive_native_init(void) { return false; }
> static inline void xive_smp_probe(void) { }
> -extern inline int xive_smp_prepare_cpu(unsigned int cpu) { return -EINVAL; }
> +static inline int xive_smp_prepare_cpu(unsigned int cpu) { return -EINVAL; }
> static inline void xive_smp_setup_cpu(void) { }
> static inline void xive_smp_disable_cpu(void) { }
> static inline void xive_kexec_teardown_cpu(int secondary) { }
>

\
 
 \ /
  Last update: 2018-01-15 10:51    [W:0.028 / U:4.060 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site