[lkml]   [2018]   [Jan]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [patch v8 3/3] platform/mellanox: mlxreg-hotplug: modify to use regmap intreface
On Thu, Jan 11, 2018 at 08:58:43AM +0000, Vadim Pasternak wrote:
> It includes:
> - restructuring of mlxreg header file for unification of hotplug items
> definition;
> - unification of hotplug items to allow any kind of item (power
> controller, fan eeprom, psu eeprom, asic health in common way);
> - utilization of regmap interface to allow independency of underlying
> hardware. It allows to support hotplug event functionality over
> programmable devices logic, when these devices can be attached to
> different interfaces types, like I2C, LPC, SPI.

This was honestly very difficult to review. This really should be several
patches which each do clearly defined things for the sake of the review process.
Doing all of the above, plus the addition of several superfluous changes for
coding style (which aren't noted above) make it very difficult to track
everything that is going on. Incremental changes lead to better code review,
fewer unintentional changes, and better code overall.

Darren Hart
VMware Open Source Technology Center

 \ /
  Last update: 2018-01-16 04:44    [W:0.139 / U:6.284 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site