lkml.org 
[lkml]   [2018]   [Jan]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH v2 14/16] remoteproc: look-up pre-registered carveout by name for carveout allocation
Date


> -----Original Message-----
> From: Bjorn Andersson [mailto:bjorn.andersson@linaro.org]
> Sent: Thursday, December 14, 2017 6:35 AM
> To: Loic PALLARDY <loic.pallardy@st.com>
> Cc: ohad@wizery.com; linux-remoteproc@vger.kernel.org; linux-
> kernel@vger.kernel.org; Arnaud POULIQUEN <arnaud.pouliquen@st.com>;
> benjamin.gaignard@linaro.org
> Subject: Re: [PATCH v2 14/16] remoteproc: look-up pre-registered carveout
> by name for carveout allocation
>
> On Thu 30 Nov 08:46 PST 2017, Loic Pallardy wrote:
> > + /* By name */
> > + mem = rproc_find_carveout_by_name(rproc, rsc->name);
> > + if (mem) {
> > + /*
> > + * Update resource table with registered carevout
> information
> > + */
> > + rsc->len = mem->len;
>
> You should validate that len, da and pa are compatible.
Yes you're right, complete definition must be checked

Regards,
Loic
>
> > + rsc->da = mem->da;
> > + rsc->pa = rproc_va_to_pa(mem->va);
> > + /* no need to register as already match one for one */
> > + return 0;
> > + }
>
> Regards,
> Bjorn

\
 
 \ /
  Last update: 2018-01-15 22:00    [W:0.067 / U:2.664 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site