lkml.org 
[lkml]   [2018]   [Jan]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] i2c: acorn: add MODULE_LICENSE tag
On Mon, Jan 15, 2018 at 6:19 PM, Russell King <linux@armlinux.org.uk> wrote:
> On Mon, Jan 15, 2018 at 06:10:28PM +0100, Wolfram Sang wrote:
>> On Thu, Jan 11, 2018 at 11:37:45AM +0100, Arnd Bergmann wrote:
>> > As of v4.15, Kbuild warns about missing MODULE_LICENSE tags:
>> >
>> > WARNING: modpost: missing MODULE_LICENSE() in drivers/i2c/busses/i2c-acorn.o
>> >
>> > This adds a license, author and description tag, matching the
>> > comment at the start of the acorn i2c driver.
>> >
>> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>>
>> Looks good, but since rmk is still around, let's add him to CC...

Oops, I just went with the default from scripts/get_maintainer.pl and
forgot to ensure the author was listed there.

>> > drivers/i2c/busses/i2c-acorn.c | 4 ++++
>> > 1 file changed, 4 insertions(+)
>> >
>> > diff --git a/drivers/i2c/busses/i2c-acorn.c b/drivers/i2c/busses/i2c-acorn.c
>> > index 9d7be5af2bf2..6463189ca183 100644
>> > --- a/drivers/i2c/busses/i2c-acorn.c
>> > +++ b/drivers/i2c/busses/i2c-acorn.c
>> > @@ -94,3 +94,7 @@ static int __init i2c_ioc_init(void)
>> > }
>> >
>> > module_init(i2c_ioc_init);
>> > +
>> > +MODULE_AUTHOR("Russell King <rmk@arm.linux.org.uk>");
>
> linux@armlinux.org.uk please - dspam on _this_ account files such mails
> into the spam mailbox.

Ok, resent now. I think what I did there was to check which address you
use most commonly in the other MODULE_AUTHOR entries.

Arnd

\
 
 \ /
  Last update: 2018-01-15 21:32    [W:0.040 / U:21.224 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site