lkml.org 
[lkml]   [2018]   [Jan]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/4] objtool: Implement jump_assert for _static_cpu_has()
On Mon, Jan 15, 2018 at 09:15:45PM +0100, Peter Zijlstra wrote:
> On Mon, Jan 15, 2018 at 01:11:51PM -0600, Josh Poimboeuf wrote:
> > Well, to clarify, it would solve _some_ of the problem. Maybe even most
> > of the problem. We'd still need to special-case jump labels in objtool
> > (like in 1/4), but that's probably not a big deal.
> >
> > So, contradicting my previous answer here... yes, it would help.
>
> OK, saves me from having to argue otherwise. My argument would've been
> that jump labels are fully described and don't need further annotation.
>
> Yes, Boris' proposal would certainly help with the alternative stuff.

Fair enough. So either annotating _static_cpu_has() or adding an
alt_instr flag works for me.

--
Josh

\
 
 \ /
  Last update: 2018-01-15 21:31    [W:0.049 / U:0.816 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site