lkml.org 
[lkml]   [2018]   [Jan]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] Documentation: i2c: drop unnecessary .owner field in examples
On Mon, Jan 15, 2018 at 2:08 PM, Nicholas Mc Guire <hofrat@osadl.org> wrote:
> From: Nicholas Mc Guire <hofrat@osadl.at>
>
> Currently there are a few drivers that still set the .owner
> in the i2c_driver structure - all of which are reported by
> coccinelle (scripts/coccinelle/api/platform_no_drv_owner.cocci)
> and there are no cases that set the .onwer and do not call any
> of the functions that set the .owner field anyway in any of the
> drivers (checked by a modified coccinelle script based on the
> above) so it seems that the examples are no longer valid and
> .owner = THIS_MODULE, can be removed here.
>
> While at it an obvious typo (new new) was also fixed.

AFAIU It is right only in case when someone does this, e.g.
module_i2c_driver() macro. Otherwise the field is pretty valid and
must be filled.


--
With Best Regards,
Andy Shevchenko

\
 
 \ /
  Last update: 2018-01-15 21:25    [W:0.080 / U:4.176 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site