lkml.org 
[lkml]   [2018]   [Jan]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: mfd/omap-usb-tll: Allocate driver data at once in usbtll_omap_probe()
On Mon, Jan 15, 2018 at 08:26:00PM +0100, SF Markus Elfring wrote:
> > dev_dbg(dev,
> > "USB TLL Rev : 0x%x not recognized, assuming %d channels\n",
> > - ver, tll->nch);
> > + ver, nch);
> > break;
>
> Does this format string need an other indentation when you touch this statement?

Well, lets that the chance and make it shorter as well:

default:
- tll->nch = OMAP_TLL_CHANNEL_COUNT;
- dev_dbg(dev,
- "USB TLL Rev : 0x%x not recognized, assuming %d channels\n",
- ver, tll->nch);
+ nch = OMAP_TLL_CHANNEL_COUNT;
+ dev_dbg(dev, "rev 0x%x not recognized, assuming %d channels\n",
+ ver, nch);
break;

Other proposals?

\
 
 \ /
  Last update: 2018-01-15 20:34    [W:0.072 / U:0.748 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site