lkml.org 
[lkml]   [2018]   [Jan]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: mfd/omap-usb-tll: Allocate driver data at once in usbtll_omap_probe()
From
Date
>> So I hope that your solution approach will be also fine.
>> Will it supersede my proposal?
>
> Who knows, perhaps it would be the best if you could judge yourself...

I am also curious on how other contributors will respond to
your following update suggestion.


> 8<--------
>
> Subject: [PATCH] mfd/omap-usb-tll: Allocate driver data at once

Would it have been clearer to use this information as the subject
for this reply already?

Are you fine with that this change approach was recorded in
a possibly questionable format?
https://patchwork.kernel.org/patch/10165193/


> Allocating memory to store clk array together with driver
> data simplifies error unwinding and allows deleting memory
> allocation failure message as there is now only single point
> where allocation could fail.

* Will it matter to mention the previous software situation a bit
in such a commit description?

* Would you like to add a tag “link”?

* Are you going to “supersede” any more source code adjustments
around questionable error messages?

Regards,
Markus

\
 
 \ /
  Last update: 2018-01-15 20:04    [W:0.074 / U:1.200 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site