lkml.org 
[lkml]   [2018]   [Jan]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[tip:x86/cleanups] x86/timer: Don't inline __const_udelay
    Commit-ID:  7cf1aaa2ad3855bd5e95bef382a66fe122fc9b01
    Gitweb: https://git.kernel.org/tip/7cf1aaa2ad3855bd5e95bef382a66fe122fc9b01
    Author: Andi Kleen <ak@linux.intel.com>
    AuthorDate: Thu, 21 Dec 2017 16:18:16 -0800
    Committer: Thomas Gleixner <tglx@linutronix.de>
    CommitDate: Sun, 14 Jan 2018 20:03:49 +0100

    x86/timer: Don't inline __const_udelay

    __const_udelay is marked inline, and LTO will happily inline it everywhere

    Dropping the inline saves ~44k text in a LTO build.

    13999560 1740864 1499136 17239560 1070e08 vmlinux-with-udelay-inline
    13954764 1736768 1499136 17190668 1064f0c vmlinux-wo-udelay-inline

    Inlining it has no advantage in general, so its the right thing to do.

    Signed-off-by: Andi Kleen <ak@linux.intel.com>
    Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
    Link: https://lkml.kernel.org/r/20171222001821.2157-2-andi@firstfloor.org

    ---
    arch/x86/lib/delay.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/arch/x86/lib/delay.c b/arch/x86/lib/delay.c
    index 553f8fd..09c83b2 100644
    --- a/arch/x86/lib/delay.c
    +++ b/arch/x86/lib/delay.c
    @@ -162,7 +162,7 @@ void __delay(unsigned long loops)
    }
    EXPORT_SYMBOL(__delay);

    -inline void __const_udelay(unsigned long xloops)
    +void __const_udelay(unsigned long xloops)
    {
    unsigned long lpj = this_cpu_read(cpu_info.loops_per_jiffy) ? : loops_per_jiffy;
    int d0;
    \
     
     \ /
      Last update: 2018-01-14 23:27    [W:4.267 / U:0.244 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site