Messages in this thread Patch in this message | | | From | Christophe JAILLET <> | Subject | [PATCH 1/4] usb: gadget: fotg210-udc: Remove a useless | Date | Fri, 12 Jan 2018 22:44:30 +0100 |
| |
There is no need to use an intermediate array for these memory allocations, so, axe it.
While at it, turn a '== NULL' into a shorter '!' when testing memory allocation failure.
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> --- drivers/usb/gadget/udc/fotg210-udc.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/usb/gadget/udc/fotg210-udc.c b/drivers/usb/gadget/udc/fotg210-udc.c index 53a48f561458..2fea32a153b7 100644 --- a/drivers/usb/gadget/udc/fotg210-udc.c +++ b/drivers/usb/gadget/udc/fotg210-udc.c @@ -1078,7 +1078,6 @@ static int fotg210_udc_probe(struct platform_device *pdev) { struct resource *res, *ires; struct fotg210_udc *fotg210 = NULL; - struct fotg210_ep *_ep[FOTG210_MAX_NUM_EP]; int ret = 0; int i; @@ -1102,10 +1101,9 @@ static int fotg210_udc_probe(struct platform_device *pdev) goto err_alloc; for (i = 0; i < FOTG210_MAX_NUM_EP; i++) { - _ep[i] = kzalloc(sizeof(struct fotg210_ep), GFP_KERNEL); - if (_ep[i] == NULL) + fotg210->ep[i] = kzalloc(sizeof(struct fotg210_ep), GFP_KERNEL); + if (!fotg210->ep[i]) goto err_alloc; - fotg210->ep[i] = _ep[i]; } fotg210->reg = ioremap(res->start, resource_size(res)); -- 2.14.1
| |