lkml.org 
[lkml]   [2018]   [Jan]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 5/6] kconfig: remove redundant input_mode test for check_conf() loop
    On Wed, Jan 10, 2018 at 7:56 AM, Masahiro Yamada
    <yamada.masahiro@socionext.com> wrote:
    > check_conf() never increments conf_cnt for listnewconfig, so conf_cnt
    > is always zero.
    >
    > In other words, conf_cnt is not zero, "input_mode != listnewconfig"
    > is met.
    >
    > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
    > ---
    >
    > scripts/kconfig/conf.c | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > diff --git a/scripts/kconfig/conf.c b/scripts/kconfig/conf.c
    > index 693cd5f..1d2ed3e 100644
    > --- a/scripts/kconfig/conf.c
    > +++ b/scripts/kconfig/conf.c
    > @@ -669,7 +669,7 @@ int main(int ac, char **av)
    > do {
    > conf_cnt = 0;
    > check_conf(&rootmenu);
    > - } while (conf_cnt && input_mode != listnewconfig);
    > + } while (conf_cnt);
    > break;
    > case alldefconfig:
    > case defconfig:
    > --
    > 2.7.4
    >

    Acked-by: Ulf Magnusson <ulfalizer@gmail.com>

    Cheers,
    Ulf

    \
     
     \ /
      Last update: 2018-01-14 23:25    [W:2.569 / U:0.044 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site