Messages in this thread | | | Date | Fri, 12 Jan 2018 14:38:57 +0100 | From | jacopo mondi <> | Subject | Re: [PATCH v4 3/9] v4l: platform: Add Renesas CEU driver |
| |
Hi Philippe, Laurent, Geert,
On Fri, Jan 12, 2018 at 11:36:31AM +0100, Philippe Ombredanne wrote: > On Tue, Jan 9, 2018 at 5:25 PM, Jacopo Mondi <jacopo+renesas@jmondi.org> wrote: > > Add driver for Renesas Capture Engine Unit (CEU). > > <snip> > > > --- /dev/null > > +++ b/drivers/media/platform/renesas-ceu.c > > @@ -0,0 +1,1648 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > <snip> > > > +MODULE_DESCRIPTION("Renesas CEU camera driver"); > > +MODULE_AUTHOR("Jacopo Mondi <jacopo+renesas@jmondi.org>"); > > +MODULE_LICENSE("GPL"); > > Jacopo, > the MODULE_LICENSE does not match the SPDX tag. Per module.h "GPL" > means GPL-2.0 or later ;) > > It should be instead: > > > +MODULE_LICENSE("GPL v2"); > > ... to match your > > > +// SPDX-License-Identifier: GPL-2.0
I will update this in next v5. Laurent, Geert: I'll keep SPDX identifier to "GPL-2.0" until kernel doc does not get updated.
Thanks j
> > I know this can be confusing, but updating the MODULE_LICENSE tags > definitions in module.h to match SPDX tags is unlikely to happen as it > would create mayhem for everyone and every module loader relying on > this established convention. > > -- > Cordially > Philippe Ombredanne
| |