Messages in this thread | | | Date | Thu, 11 Jan 2018 17:44:24 +0100 | From | Peter Zijlstra <> | Subject | Re: [PATCH 2/3] objtool: Ignore retpoline alternatives |
| |
On Thu, Jan 11, 2018 at 10:33:26AM -0600, Josh Poimboeuf wrote: > On Thu, Jan 11, 2018 at 04:27:38PM +0000, David Woodhouse wrote: > > On Wed, 2018-01-10 at 19:48 -0600, Josh Poimboeuf wrote: > > > > > > +#define ANNOTATE_NOSPEC_ALTERNATIVE \ > > > + "999:\n\t" \ > > > + ".pushsection .discard.nospec\n\t" \ > > > + ".long 999b - .\n\t" \ > > > + ".popsection\n\t" > > > + > > > > <mode name="peterz"> > > Ick, numbers. Use .Lfoo_%= instead. > > </mode> > > I seem to recall that not working with inline asm, maybe old versions of > GCC don't like it or something? I can try it and see if 0-day bot > complains.
Note that we'll raise the GCC limit to 4.5 soon to mandate asm-goto, for x86 at least.
| |