lkml.org 
[lkml]   [2018]   [Jan]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] drm/panel: lvds: Handle the optional regulator case properly
Date
On Thu, 11 Jan 2018, Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote:
> My preference, however, would be for devm_regulator_get_optional() to return
> NULL when no regulator is present. The current implementation returns -ENODEV
> in multiple cases, making it impossible to properly discriminate between
> having no regulator and not being able to get the regulator due to an error.

Just a word of warning, IS_ERR(NULL) is false, and your proposed change
would apparently require quite a churn all over the kernel.

BR,
Jani.


--
Jani Nikula, Intel Open Source Technology Center

\
 
 \ /
  Last update: 2018-01-14 23:23    [W:0.277 / U:0.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site