lkml.org 
[lkml]   [2018]   [Jan]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v1 2/4] ARM: PWM: add allwinner sun8i R40/V40/T3 pwm support.
Hi,

On Thu, Jan 11, 2018 at 07:32:41PM +0800, hao_zhang wrote:
> This patch add allwinner sun8i R40/V40/T3 pwm support.
>
> Signed-off-by: hao_zhang <hao5781286@gmail.com>

I don't really know the PWM framework, so I'll obviously leave that
part to Thierry, but the DT and probe parts look ok.

You have a number of issues with checkpatch though still, please run
./scripts/checkpatch.pl --strict, and once all the issues have been
fixed:
Reviewed-by: Maxime Ripard <maxime.ripard@free-electrons.com>

Thanks!
Maxime

--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2018-01-14 23:23    [W:0.189 / U:0.260 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site