lkml.org 
[lkml]   [2018]   [Jan]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 03/32] fs: introduce new ->get_poll_head and ->poll_mask methods
On Thu, Jan 11, 2018 at 05:22:00AM +0000, Al Viro wrote:
> Whee... The very first ->poll() instance in alphabetic order on pathnames:
> in arch/cris/arch-v10/drivers/gpio.c
>
> static __poll_t gpio_poll(struct file *file, poll_table *wait)
> {
> __poll_t mask = 0;
> struct gpio_private *priv = file->private_data;
> unsigned long data;
> unsigned long flags;
>
> spin_lock_irqsave(&gpio_lock, flags);
>
> poll_wait(file, &priv->alarm_wq, wait);
>
> IOW, we are doing poll_wait() (== possible GFP_KERNEL __get_free_page()) under
> a spinlock...

Yes. Another god reason to separate poll_wait and the actual
event check callback..

\
 
 \ /
  Last update: 2018-01-14 23:22    [W:0.362 / U:0.336 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site