lkml.org 
[lkml]   [2018]   [Jan]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH linux dev-4.10 3/6] drivers/misc: Add driver for Aspeed PECI and generic PECI headers
From
Date
On 1/10/2018 2:20 AM, Greg KH wrote:
> On Tue, Jan 09, 2018 at 02:31:23PM -0800, Jae Hyun Yoo wrote:
>> +#pragma pack(push, 1)
>> +struct peci_xfer_msg {
>> + unsigned char client_addr;
>> + unsigned char tx_len;
>> + unsigned char rx_len;
>> + unsigned char tx_buf[MAX_BUFFER_SIZE];
>> + unsigned char rx_buf[MAX_BUFFER_SIZE];
>> +};
>> +#pragma pack(pop)
>
> For any structure that crosses the user/kernel boundry, you _HAVE_ to
> use the "__" variant. So for here you would use __u8 instead of
> "unsigned char" in order for things to work properly.
>
> I'm guessing you didn't test this all out on a mixed 32/64 bit system?
>
> Please fix up and test to ensure that it all works properly before
> resubmitting.
>
> thanks,
>
> greg k-h
>

Thanks for your pointing it out. I'll fix this.

Thanks a lot,
Jae

\
 
 \ /
  Last update: 2018-01-14 23:22    [W:0.738 / U:0.204 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site