Messages in this thread | | | Date | Wed, 10 Jan 2018 14:45:07 +0900 | From | Namhyung Kim <> | Subject | Re: [PATCH v8 00/37] tracing: Inter-event (e.g. latency) support |
| |
On Thu, Dec 21, 2017 at 10:02:22AM -0600, Tom Zanussi wrote: > Hi, > > This is V8 of the inter-event tracing patchset, addressing input from > V7. > > These changes address Namhyung's most recent comments (thanks, > Namhyung!) and move everything to the latest tracing/for-next: > > - moved a couple hunks switching hist_field_fn_t params from 15/37 > (add variable support) to 20/37 (Pass tracing_map_elt to > hist_field_accessor) > - in hist_trigger_elt_data_alloc(), remove the unnecessary '+1' from > TASK_COMM_LEN size. > - simplified find_var_file() code according to Namhyung's > suggestions. > - fixed bug in print_synth_event() where entry->fields was being > used instead of the address as it should have been
I only have a nitpick in the patch 24 but otherwise cannot find an issue anymore, so
Reviewed-by: Namhyung Kim <namhyung@kernel.org>
Thanks, Namhyung
| |