[lkml]   [2018]   [Jan]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: thermal/drivers/hisi: Remove bogus const from function return type
Hello Geert,

On Sun, Nov 19, 2017 at 12:04:27PM +0100, Geert Uytterhoeven wrote:
> With gcc-4.1.2:
> drivers/thermal/hisi_thermal.c: In function ‘hisi_thermal_probe’:
> drivers/thermal/hisi_thermal.c:530: warning: type qualifiers ignored on function return type
> Remove the "const" keyword to fix this.


I intentionally asked Daniel to include the modifier because sparse
pointed this to me:

This patch adds this issue to hisi driver (sparse)

drivers/thermal/hisi_thermal.c:398:24: warning: incorrect type in assignment (different modifiers)
drivers/thermal/hisi_thermal.c:398:24: expected int ( *platform_probe )( ... )
drivers/thermal/hisi_thermal.c:398:24: got void const *

which makes sense to me to be const, given that it is receiving the return
of a function which returns a const void *.
nclude/linux/of_device.h:extern const void *of_device_get_match_data(const struct device *dev);


 \ /
  Last update: 2018-01-01 19:22    [W:0.050 / U:30.348 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site