Messages in this thread | | | Date | Fri, 8 Sep 2017 16:40:28 +0200 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH net-next v2 02/10] net: dsa: debugfs: add tree |
| |
On Fri, Sep 08, 2017 at 10:18:27AM -0400, Vivien Didelot wrote: > Hi Greg, > > Can I ask for a quick review of this patch as well? It's the one adding > the boilerplate for a single debugfs file, and I'm pretty sure it can be > reduced somehow.
I don't see a patch here :(
> Also more important, you will notice what seems to be a bug to me: > I can read or write a file even if I didn't mask the corresponding mode, > hence the double check in dsa_debugfs_show and dsa_debugfs_write.
The mode can be changed by userspace, you shouldn't ever need to check it in any debugfs calls, right?
thanks,
greg k-h
| |