lkml.org 
[lkml]   [2017]   [Sep]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.13 16/47] iio: adc: ti-ads1015: dont return invalid value from buffer setup callbacks
    Date
    4.13-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Akinobu Mita <akinobu.mita@gmail.com>

    commit a6fe5e52d5ecfc98530034d6c9db73777cf41ede upstream.

    pm_runtime_get_sync() and pm_runtime_put_autosuspend() return 0 on
    success, 1 if the device's runtime PM status was already requested status
    or error code on failure. So a positive return value doesn't indicate an
    error condition.

    However, any non-zero return values from buffer preenable and postdisable
    callbacks are recognized as an error and this driver reuses the return
    value from pm_runtime_get_sync() and pm_runtime_put_autosuspend() in
    these callbacks. This change fixes the false error detections.

    Cc: Daniel Baluta <daniel.baluta@gmail.com>
    Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
    Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/iio/adc/ti-ads1015.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/iio/adc/ti-ads1015.c
    +++ b/drivers/iio/adc/ti-ads1015.c
    @@ -235,7 +235,7 @@ static int ads1015_set_power_state(struc
    ret = pm_runtime_put_autosuspend(dev);
    }

    - return ret;
    + return ret < 0 ? ret : 0;
    }

    static

    \
     
     \ /
      Last update: 2017-09-08 15:21    [W:4.247 / U:0.232 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site