Messages in this thread | | | Subject | Re: [PATCH] gpio: thunderx: select IRQ_DOMAIN_HIERARCHY instead of depends on | From | David Daney <> | Date | Tue, 5 Sep 2017 19:09:31 -0700 |
| |
On 09/05/2017 06:40 PM, Masahiro Yamada wrote: > IRQ_DOMAIN_HIERARCHY is not user-configurable, but supposed to be > selected by drivers that need IRQ domain hierarchy support. > > GPIO_THUNDERX is the only user of "depends on IRQ_DOMAIN_HIERARCHY". > This means, we can not enable GPIO_THUNDERX unless other drivers > select IRQ_DOMAIN_HIERARCHY elsewhere. This is odd. Flip the logic. > > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
IRQ_DOMAIN_HIERARCHY is set as a result of ARCH_THUNDER (this SoC hardware), so it actually works as-is. That said, this looks like a reasonable improvement, and will allow the COMPILE_TEST to enable it, so...
Acked-by: David Daney <david.daney@cavium.com>
> --- > > drivers/gpio/Kconfig | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig > index 3388d54..3f80f16 100644 > --- a/drivers/gpio/Kconfig > +++ b/drivers/gpio/Kconfig > @@ -453,7 +453,8 @@ config GPIO_TS4800 > config GPIO_THUNDERX > tristate "Cavium ThunderX/OCTEON-TX GPIO" > depends on ARCH_THUNDER || (64BIT && COMPILE_TEST) > - depends on PCI_MSI && IRQ_DOMAIN_HIERARCHY > + depends on PCI_MSI > + select IRQ_DOMAIN_HIERARCHY > select IRQ_FASTEOI_HIERARCHY_HANDLERS > help > Say yes here to support the on-chip GPIO lines on the ThunderX >
| |