lkml.org 
[lkml]   [2017]   [Sep]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v2 01/40] tracing: Exclude 'generic fields' from histograms
    Date
    There are a small number of 'generic fields' (comm/COMM/cpu/CPU) that
    are found by trace_find_event_field() but are only meant for
    filtering. Specifically, they unlike normal fields, they have a size
    of 0 and thus wreak havoc when used as a histogram key.

    Exclude these (return -EINVAL) when used as histogram keys.

    Signed-off-by: Tom Zanussi <tom.zanussi@linux.intel.com>
    ---
    kernel/trace/trace_events_hist.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/kernel/trace/trace_events_hist.c b/kernel/trace/trace_events_hist.c
    index 1c21d0e..7eb975a 100644
    --- a/kernel/trace/trace_events_hist.c
    +++ b/kernel/trace/trace_events_hist.c
    @@ -450,7 +450,7 @@ static int create_val_field(struct hist_trigger_data *hist_data,
    }

    field = trace_find_event_field(file->event_call, field_name);
    - if (!field) {
    + if (!field || !field->size) {
    ret = -EINVAL;
    goto out;
    }
    @@ -548,7 +548,7 @@ static int create_key_field(struct hist_trigger_data *hist_data,
    }

    field = trace_find_event_field(file->event_call, field_name);
    - if (!field) {
    + if (!field || !field->size) {
    ret = -EINVAL;
    goto out;
    }
    --
    1.9.3
    \
     
     \ /
      Last update: 2017-09-06 00:10    [W:4.024 / U:0.072 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site