Messages in this thread | | | Date | Tue, 5 Sep 2017 18:46:50 +0300 | From | "Kirill A. Shutemov" <> | Subject | Re: [PATCH] mm: Fix mem_cgroup_oom_disable() call missing |
| |
On Tue, Sep 05, 2017 at 05:30:39PM +0200, Laurent Dufour wrote: > Seen while reading the code, in handle_mm_fault(), in the case > arch_vma_access_permitted() is failing the call to mem_cgroup_oom_disable() > is not made. > > To fix that, move the call to mem_cgroup_oom_enable() after calling > arch_vma_access_permitted() as it should not have entered the memcg OOM. > > Fixes: bae473a423f6 ("mm: introduce fault_env") > Signed-off-by: Laurent Dufour <ldufour@linux.vnet.ibm.com>
Ouch. Sorry for this.
Acked-by: Kirill A. Shutemov <kirill@shutemov.name>
Cc: stable@ is needed too.
It's strange we haven't seen reports of warning from mem_cgroup_oom_enable().
-- Kirill A. Shutemov
| |