Messages in this thread | | | Subject | Re: [PATCH] hwmon: (k10temp) Add support for family 17h | From | Guenter Roeck <> | Date | Tue, 5 Sep 2017 06:35:33 -0700 |
| |
On 09/04/2017 11:47 PM, Clemens Ladisch wrote: > Guenter Roeck wrote: >> Add support for temperature sensors on Family 17h (Ryzen) processors. >> >> Signed-off-by: Guenter Roeck <linux@roeck-us.net> >> --- >> Some of this is guesswork, but afaics it is working. No idea if there >> is a better way to determine the temperature offset. > > The reported value is not an absolute temperature on any CPU. > > As far as I know, the offset is not guaranteed to be fixed for any model, > i.e., it would be pointless to apply the offset observed on one specific > chip. >
What we should do then, as we did for coretemp, would be to collect the various temperature offsets (and temperature limits, for that matter) and apply per-CPU adjustments. Are the offsets documented somewhere ?
>> @@ -25,6 +25,10 @@ >> #include <linux/pci.h> >> #include <asm/processor.h> >> >> +#ifndef PCI_DEVICE_ID_AMD_17H_DF_F3 >> +#define PCI_DEVICE_ID_AMD_17H_DF_F3 0x1463 >> +#endif >> + > > Please move this down to the other symbols. > Done.
Thanks, Guenter
| |