[lkml]   [2017]   [Sep]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v7 00/19] simplify crypto wait for async op
On Tue, Sep 5, 2017 at 2:23 PM, Harsh Jain <> wrote:
> On Sun, Sep 3, 2017 at 11:47 AM, Gilad Ben-Yossef <> wrote:
>> On Thu, Aug 31, 2017 at 3:31 PM, Harsh Jain <> wrote:
>>> HI Gilad,
>>> I think we need an update in ESP also. Now EBUSY return means driver
>>> has accepted, Packet should not be dropped in
>>> esp_output_tail() function.
>> Good catch. You are right and the same holds true for ah_output() in ah4.c.
>> But I do wonder, the code there now treats -EBUSY as a special case
>> and returns NET_XMIT_DROP
>> but if an AEAD or AHASH transformation return some other error, like
>> -ENOMEM or -EINVAL shouldn't
>> we return NET_XMIT_DROP in that case too?
> I think we should not, XMIT_DROP implies drop current packet only,
> later on when device is recovered from busy state, Upper layer
> protocol(TCP) will re-transmit the packet. It helps in flow control.

I see. Makes sense.


Gilad Ben-Yossef
Chief Coffee Drinker

"If you take a class in large-scale robotics, can you end up in a
situation where the homework eats your dog?"
-- Jean-Baptiste Queru

 \ /
  Last update: 2017-09-05 14:17    [W:0.066 / U:7.724 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site