Messages in this thread | | | Date | Mon, 04 Sep 2017 15:50:50 +0200 | From | Takashi Iwai <> | Subject | Re: [PATCH v2 1/3] mfd: Add support for Cherry Trail Dollar Cove TI PMIC |
| |
On Mon, 04 Sep 2017 15:37:32 +0200, Lee Jones wrote: > > > +static struct mfd_cell dc_ti_dev[] = { > > + { > > + .name = "dc_ti_pwrbtn", > > + .num_resources = ARRAY_SIZE(power_button_resources), > > + .resources = power_button_resources, > > + }, > > + { > > Place these on the same line.
Does this and ...
> > + }, > > + { > > + .name = "dc_ti_region", > > + }, > > This should be a one line entry: > > { .name = "dc_ti_region" },
.... this match together? The result would be like:
static struct mfd_cell dc_ti_dev[] = { { .name = "dc_ti_pwrbtn", .num_resources = ARRAY_SIZE(power_button_resources), .resources = power_button_resources, }, { .name = "chtdc_ti_adc", .num_resources = ARRAY_SIZE(adc_resources), ..... }, { .name = "chtdc_ti_region", }, };
which I find a bit inconsistent.
thanks,
Takashi
| |