Messages in this thread | | | From | Andy Shevchenko <> | Date | Sun, 3 Sep 2017 15:34:09 +0300 | Subject | Re: [RFC v2 1/6] platform/x86: intel_pmc_ipc: Use devm_* calls in driver probe function |
| |
On Sun, Sep 3, 2017 at 4:24 AM, <sathyanarayanan.kuppuswamy@linux.intel.com> wrote: > From: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com> > > This patch cleans up unnecessary free/alloc calls in ipc_plat_probe(), > ipc_pci_probe() and ipc_plat_get_res() functions by using devm_* > calls. > > This patch also adds proper error handling for failure cases in > ipc_pci_probe() function.
> ret = pci_enable_device(pdev); > if (ret) > - return ret; > + goto release_device;
Instead you should use PCI managed function(s).
-- With Best Regards, Andy Shevchenko
| |