Messages in this thread | | | Date | Thu, 28 Sep 2017 10:13:36 -0700 (PDT) | Subject | Re: [PATCH net] net: dsa: Fix network device registration order | From | David Miller <> |
| |
From: Florian Fainelli <f.fainelli@gmail.com> Date: Mon, 25 Sep 2017 15:55:53 -0700
> We cannot be registering the network device first, then setting its > carrier off and finally connecting it to a PHY, doing that leaves a > window during which the carrier is at best inconsistent, and at worse > the device is not usable without a down/up sequence since the network > device is visible to user space with possibly no PHY device attached. > > Re-order steps so that they make logical sense. This fixes some devices > where the port was not usable after e.g: an unbind then bind of the > driver. > > Fixes: 0071f56e46da ("dsa: Register netdev before phy") > Fixes: 91da11f870f0 ("net: Distributed Switch Architecture protocol support") > Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Applied and queued up for -stable.
| |