lkml.org 
[lkml]   [2017]   [Sep]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH RFC 0/6] Modify KSZ9477 DSA driver in preparation to add other KSZ switch drivers.
Hi!

> > > drivers/net/dsa/microchip/Makefile | 2 +-
> > > drivers/net/dsa/microchip/ksz9477.c | 1317
> > ++++++++++++++++++++++++++++++++
> >
> > We already have ksz_9477_reg.h. So should this be ksz_9477.c for
> > consistency?
>
> The product name is KSZ9477 and other switches are also like KSZ####,
> so I would prefer to have no separation between KSZ and the product
> number. I think the file ksz_9477_reg.h was named that way because
> the other files were named ksz_common.c and ksz_spi.c. If need to
> we can change the file name.

I don't care either way, but please make it consistent.

Thanks,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2017-09-28 17:26    [W:0.064 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site