Messages in this thread | | | Date | Thu, 28 Sep 2017 16:50:14 +0300 | From | Leon Romanovsky <> | Subject | Re: [PATCH for-next 2/9] RDMA/hns: Factor out the code for checking sdb status into a new function |
| |
On Thu, Sep 28, 2017 at 12:57:27PM +0800, Wei Hu (Xavier) wrote: > From: Lijun Ou <oulijun@huawei.com> > > It mainly places the lines for checking send doorbell status > into a special functions. As a result, we can directly call it in > check_qp_db_process_status function and keep consistent indenting > style. > > It fixes: 5f110ac4bed8 ("IB/hns: Fix for checkpatch.pl comment style)
You forgot " at the end of the line, and there is need to put fixes (should be Fixes) in the line before Signed-off-by.
> The warning from static checker: > drivers/infiniband/hw/hns/hns_roce_hw_v1.c:3562 check_qp_db_process_status() > warn: inconsistent indenting > > Signed-off-by: Lijun Ou <oulijun@huawei.com> > Signed-off-by: Wei Hu (Xavier) <xavier.huwei@huawei.com> > Signed-off-by: Shaobo Xu <xushaobo2@huawei.com> > --- > drivers/infiniband/hw/hns/hns_roce_hw_v1.c | 95 ++++++++++++++++-------------- > 1 file changed, 51 insertions(+), 44 deletions(-) > [unhandled content-type:application/pgp-signature] | |