Messages in this thread | | | Date | Thu, 28 Sep 2017 13:12:32 +0200 | From | Steffen Klassert <> | Subject | Re: [PATCH] xfrm: don't call xfrm_policy_cache_flush under xfrm_state_lock |
| |
On Wed, Sep 27, 2017 at 02:31:03PM +0200, Florian Westphal wrote: > Artem Savkov <asavkov@redhat.com> wrote: > > I might be wrong but it doesn't look like xfrm_state_lock is required > > for xfrm_policy_cache_flush and calling it under this lock triggers both > > "sleeping function called from invalid context" and "possible circular > > locking dependency detected" warnings on flush. > > > > Fixes: ec30d78c14a8 xfrm: add xdst pcpu cache > > Signed-off-by: Artem Savkov <asavkov@redhat.com> > > You're right, its not needed (and wrong). > > Acked-by: Florian Westphal <fw@strlen.de>
Applied to the ipsec tree, thanks everyone!
| |