Messages in this thread | | | Date | Thu, 28 Sep 2017 12:36:05 +0800 | From | jeffy <> | Subject | Re: [PATCH] irq/generic-chip: Fix memory leak of domain->name |
| |
Hi Thomas,
On 09/28/2017 11:18 AM, jeffy wrote: >> >> I don't think that this is the proper thing to do. There is no reason why >> the domain should have the same name as the irq chip. So we rather should >> do: >> >> if (!d->name) >> d->name = name; >> >> Along with a proper comment. > that is better, will do it in next version :)
it looks like the __irq_domain_add() would guarantee every domain has a valid name, maybe we can just remove this?
| |