Messages in this thread | | | From | Felipe Balbi <> | Subject | Re: [PATCH v2 27/31] usb/gadget/snps_udc_core: Remove struct timer_list.data use | Date | Thu, 28 Sep 2017 12:36:37 +0300 |
| |
Kees Cook <keescook@chromium.org> writes:
> If the probe fails, udc_remove() will not be called, so there is no > reason to make del_timer_sync() calls conditional. As a result, use of > the .data field can be dropped, in support of making removing this field > entirely from struct timer_list. > > Cc: Felipe Balbi <balbi@kernel.org> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Cc: Raviteja Garimella <raviteja.garimella@broadcom.com> > Cc: Michal Nazarewicz <mina86@mina86.com> > Cc: "Gustavo A. R. Silva" <garsilva@embeddedor.com> > Cc: linux-usb@vger.kernel.org > Signed-off-by: Kees Cook <keescook@chromium.org>
Acked-by: Felipe Balbi <felipe.balbi@linux.intel.com>
-- balbi [unhandled content-type:application/pgp-signature] | |