Messages in this thread | | | Date | Wed, 27 Sep 2017 14:59:27 -0700 | From | Darren Hart <> | Subject | Re: [PATCH 11/12] platform/x86: dell-wmi-smbios: introduce character device for userspace |
| |
On Wed, Sep 27, 2017 at 09:12:34PM +0000, Mario.Limonciello@dell.com wrote: ... > > Thanks for the concrete example, this helps a lot. > > > > One guiding principle of this series and something Pali correctly pointed out, > > is that for Linux, we're keeping WMI as the implementation and exposing features > > to userspace through char devs and IOCTLS. You points above are consistent with > > that theme, and the GUIDs are not an appropriate namespace. > > > > The driver namespace does make more sense as you suggested above: > > > > /dev/wmi/$driver > > > > This still has wmi in the name, but given that is the bus name, I think it's a > > reasonable way organize the files - and is still a well-defined naming scheme. > > > > Thanks Darren. I'll adjust the patch. > Would you like me to document this chosen policy somewhere in Documentation? > If so, where? > Or to put more about our conversation in the commit message? >
Some justification in the commit message for now would be best. Thanks!
-- Darren Hart VMware Open Source Technology Center
| |