Messages in this thread | | | Date | Wed, 27 Sep 2017 17:46:44 +0300 | From | Leon Romanovsky <> | Subject | Re: [PATCH] IB/mlx5:: pr_err() and mlx5_ib_dbg() strings should end with newlines |
| |
On Wed, Sep 27, 2017 at 10:20:39AM -0400, Doug Ledford wrote: > On Tue, 2017-09-26 at 12:11 -0700, Joe Perches wrote: > > On Tue, 2017-09-26 at 18:50 +0300, Leon Romanovsky wrote: > > > So how can I reproduce the different output before and after this > > > change? > > > > Try lib/test_module.c with and without the newline > > on "Hello, World" on a quiescent system. > > I agree here. The newlines are still worthwhile as they remove any > unnecessary stalls in the printk output while the printk engine decides > whether or not you are going to do a KERN_CONT print next. > > Thanks, applied.
Thanks
> > -- > Doug Ledford <dledford@redhat.com> > GPG KeyID: B826A3330E572FDD > Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD > [unhandled content-type:application/pgp-signature] | |